Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of string identifiers in Phase #724

Closed
wants to merge 3 commits into from
Closed

Remove duplication of string identifiers in Phase #724

wants to merge 3 commits into from

Commits on Oct 7, 2019

  1. [Thermo] deprecate name/id support in Phase::speciesIndex

    Ingmar Schoegl committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    ea65ba6 View commit details
    Browse the repository at this point in the history

  2. [Equil] replace references to Phase::name by Phase::id 

    * reference phases using Phase::id instead
* create private vcs_VolPhase::m_phaseID
* vcs_VolPhase::PhaseID() replaces vcs_VolPhase::PhaseName
* clarify conflation of 'phase id' in vcs_solve (which references a numeric
phase number) rather than a string 'phase id' as used elsewhere
* i.e. VCS_SOLVE::m_phaseNum replaces VCS_SOLVE::m_phaseID
    @ischoegl
    ischoegl committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    3c98504 View commit details
    Browse the repository at this point in the history

  3. [Thermo] replace remaining references to Phase::name by Phase::id

    @ischoegl
    ischoegl committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    5bf6357 View commit details
    Browse the repository at this point in the history