Build the samples on the CI services #649
Conversation
zerodim.h used to have Func1.h included indirectly, so make it explicit.
For samples, make sure that OpenMP and Accelerate are not exclusive options on macOS
Apple's clang on macOS requires the libomp to link. Apple symlinks gcc to clang, so it can't be detected as clang by executable name
bryanwweber
force-pushed
the
build_samples_on_ci
branch
2 times, most recently
from
f973ebb
to
7985ff6
Compare
|
I guess this supersedes #647. Whoops! |
| @@ -51,7 +51,7 @@ void run() | |||
| // thread in cases where the workload is biased, e.g. calculations for low | |||
| // T0 take longer than calculations for high T0. | |||
| #pragma omp parallel for schedule(static, 1) | |||
| for (size_t i = 0; i < nPoints; i++) { | |||
| for (int i = 0; i < nPoints; i++) { | |||
There was a problem hiding this comment.
Needing to change this to a signed type is unfortunate. In this case, nPoints should also be changed to an int, as well other variables which are compared to nPoints (i.e. the loop index in the preceding loop) to avoid compiler warnings about "comparison between signed and unsigned integer expressions".
Requires libomp on macOS from homebrew. OpenMP with Visual C/C++ requires the loop index to be a signed type (from OpenMP < 3.0).
bryanwweber
force-pushed
the
build_samples_on_ci
branch
from
7985ff6
to
fb14816
Compare
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=========================================
+ Coverage 68.49% 68.5% +<.01%
=========================================
Files 368 368
Lines 40027 40027
=========================================
+ Hits 27418 27419 +1
+ Misses 12609 12608 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=========================================
+ Coverage 68.49% 68.5% +<.01%
=========================================
Files 368 368
Lines 40027 40027
=========================================
+ Hits 27418 27419 +1
+ Misses 12609 12608 -1
Continue to review full report at Codecov.
|
Func1.hinzerodim.h, it had been previously implicitly included but was inadvertently removed in Improve ReactorNet infrastructure for alternative FlowDevice and Wall objects #632