-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of Peng-Robinson EoS #641
Commits on Mar 19, 2021
-
Implementation of Peng-Robinson equation of state.
Implemetation of Peng-Robinson equation of state added factories for FlowDevice and Wall objects Updating `thermo/PengRobinsonMFPT` class addition. -Adds `test/data/co2_PR_exmample.cti` for testing. -Corrects typo in `src/thermo/PengRobinsonMFTP::setSpeciesCoeffs` -Minor formatting changes (indentations) -Change how `Vroot_` is initialized. Updating ctml_writer.py to include acentric_factor Updating a typo in PengRobinsonMFTP.cpp Updating ctml_writer.py to add units for b_coeff Updating ctml_writer.py to add units for b_coeff with correct indentation Correcting a mistake in the getActivityCoefficient subroutine Updating PengRobinson_Test.cpp with accurate hard-coded values Adding a test getPressure in PengRobinsonMFTP_Test.cpp file Fixing tabs and spaces Replacing 'doublereal' with 'double' Fixing tabs and spaces in the CTI file Adding comments and renaming few parameter names Fixing tabs and spaces Following modifications in the code are performed: 1. Fixing typos 2. Adding more detailed documentation 3. Deleting redundant variables Fixing typos and comments in the cubic solver Fixing typos in PengRobinsonMFTP.h Replacing (molecularWt/rho) calculations by molarVolume() function Modifying tests with tighter tolerances Modifying comments and reference for cubic solver Replacing sqrt(2) with math constant M_SQRT2 Modification in cubic solver with additional comments and removal of redundant code
Configuration menu - View commit details
-
Copy full SHA for 83080a1 - Browse repository at this point
Copy the full SHA 83080a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9145df - Browse repository at this point
Copy the full SHA f9145dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 151a486 - Browse repository at this point
Copy the full SHA 151a486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fbb73f - Browse repository at this point
Copy the full SHA 3fbb73fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b0d1333 - Browse repository at this point
Copy the full SHA b0d1333View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bee6cf - Browse repository at this point
Copy the full SHA 1bee6cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ffbe6b - Browse repository at this point
Copy the full SHA 0ffbe6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa3c776 - Browse repository at this point
Copy the full SHA fa3c776View commit details -
Fix species coefficient updates in PengRobinson.
-Species coefficients were using phase critical termperature, rather than species critical temepratures. -Fixing this required updates to regression tests. -Removed commented code from previous commit (removing XML capabilities)
Configuration menu - View commit details
-
Copy full SHA for bc06b6d - Browse repository at this point
Copy the full SHA bc06b6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf5102a - Browse repository at this point
Copy the full SHA bf5102aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4680886 - Browse repository at this point
Copy the full SHA 4680886View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f59243 - Browse repository at this point
Copy the full SHA 9f59243View commit details -
Adding ThermoFromYAML:PengRobinson_CO2 test
- Creates CO2-PR phase in test/data/thermo-models.yaml - Creates `PengRobinson_CO2` test in test/thermo/thermoFromYAML.cpp - Fixes minor capitalization typo in PengRobinson:calculateAlpha
Configuration menu - View commit details
-
Copy full SHA for c40bd53 - Browse repository at this point
Copy the full SHA c40bd53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ee1372 - Browse repository at this point
Copy the full SHA 8ee1372View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d520a - Browse repository at this point
Copy the full SHA 09d520aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 759e738 - Browse repository at this point
Copy the full SHA 759e738View commit details -
Testing critical property lookup for PengRobinson.
Deletes CO2 interaction parameters from co2_PR_example.yaml, such that phase construction in PengRobinson_Test.cpp covers the cirtical property lookup capabilities in PengRobinson::getCoeff. Note that this required changing some of the regression test expected values, as the critical properties don't correspond perfectly with the interaction parameters previously stored in co2_PR_exmple.yaml.
Configuration menu - View commit details
-
Copy full SHA for ffee0f7 - Browse repository at this point
Copy the full SHA ffee0f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for defe2df - Browse repository at this point
Copy the full SHA defe2dfView commit details -
Add functions for factory alias management
This allows for error checking at the time of adding the alias, as well as providing a public interface for adding aliases.
Configuration menu - View commit details
-
Copy full SHA for 835198e - Browse repository at this point
Copy the full SHA 835198eView commit details -
Implementation of Peng-Robinson equation of state.
Implemetation of Peng-Robinson equation of state added factories for FlowDevice and Wall objects Updating `thermo/PengRobinsonMFPT` class addition. -Adds `test/data/co2_PR_exmample.cti` for testing. -Corrects typo in `src/thermo/PengRobinsonMFTP::setSpeciesCoeffs` -Minor formatting changes (indentations) -Change how `Vroot_` is initialized. Updating ctml_writer.py to include acentric_factor Updating a typo in PengRobinsonMFTP.cpp Updating ctml_writer.py to add units for b_coeff Updating ctml_writer.py to add units for b_coeff with correct indentation Correcting a mistake in the getActivityCoefficient subroutine Updating PengRobinson_Test.cpp with accurate hard-coded values Adding a test getPressure in PengRobinsonMFTP_Test.cpp file Fixing tabs and spaces Replacing 'doublereal' with 'double' Fixing tabs and spaces in the CTI file Adding comments and renaming few parameter names Fixing tabs and spaces Following modifications in the code are performed: 1. Fixing typos 2. Adding more detailed documentation 3. Deleting redundant variables Fixing typos and comments in the cubic solver Fixing typos in PengRobinsonMFTP.h Replacing (molecularWt/rho) calculations by molarVolume() function Modifying tests with tighter tolerances Modifying comments and reference for cubic solver Replacing sqrt(2) with math constant M_SQRT2 Modification in cubic solver with additional comments and removal of redundant code
Configuration menu - View commit details
-
Copy full SHA for 8edf261 - Browse repository at this point
Copy the full SHA 8edf261View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc650ad - Browse repository at this point
Copy the full SHA fc650adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ecfec3 - Browse repository at this point
Copy the full SHA 6ecfec3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2ec337 - Browse repository at this point
Copy the full SHA d2ec337View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8828ef9 - Browse repository at this point
Copy the full SHA 8828ef9View commit details -
Cleaning up typos and merge conflicts.
Cleaning up merge conflicts in src/thermo/PengRobinson.cpp Cleaning up `addAlias` typos in src/thermo/ThermoFactory.cpp
Configuration menu - View commit details
-
Copy full SHA for ef8b92c - Browse repository at this point
Copy the full SHA ef8b92cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8ff389 - Browse repository at this point
Copy the full SHA b8ff389View commit details -
Configuration menu - View commit details
-
Copy full SHA for dfdaa82 - Browse repository at this point
Copy the full SHA dfdaa82View commit details -
Adding following tests to PengRobinson_Test.cpp to verify that
1. g = h- T*s 2. cp = dH/dT at constant pressure using Finite difference method 3. molar enthalpy = \sum x_k h_k
Configuration menu - View commit details
-
Copy full SHA for 32af524 - Browse repository at this point
Copy the full SHA 32af524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1eca522 - Browse repository at this point
Copy the full SHA 1eca522View commit details -
Cleaning up thermo/PengRobinson
-Temperature input not needed in PengRobinson:calculateAB -Unused variable RT in PengRobinson_Test/totalEnthalpy -Replacing duplicative code with call to calcualteAB
Configuration menu - View commit details
-
Copy full SHA for 26149ca - Browse repository at this point
Copy the full SHA 26149caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7402961 - Browse repository at this point
Copy the full SHA 7402961View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb97af2 - Browse repository at this point
Copy the full SHA bb97af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5032994 - Browse repository at this point
Copy the full SHA 5032994View commit details -
Configuration menu - View commit details
-
Copy full SHA for 423154f - Browse repository at this point
Copy the full SHA 423154fView commit details -
Removing dependancy of EoS specific omega_a, omega_b parameters from …
…solveCubic function in MixtureFugacityTP class.
Configuration menu - View commit details
-
Copy full SHA for e6f6b9d - Browse repository at this point
Copy the full SHA e6f6b9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04f0a80 - Browse repository at this point
Copy the full SHA 04f0a80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b66d5 - Browse repository at this point
Copy the full SHA 92b66d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c6844 - Browse repository at this point
Copy the full SHA 29c6844View commit details -
Removing getChemPotentials_RT function from PengRobinsonMFTP since it is
already defined in the parent class MixtureFugacityTP.
Configuration menu - View commit details
-
Copy full SHA for 83bc2be - Browse repository at this point
Copy the full SHA 83bc2beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 768053c - Browse repository at this point
Copy the full SHA 768053cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e69a65 - Browse repository at this point
Copy the full SHA 7e69a65View commit details -
Configuration menu - View commit details
-
Copy full SHA for fded715 - Browse repository at this point
Copy the full SHA fded715View commit details -
Configuration menu - View commit details
-
Copy full SHA for df22aa7 - Browse repository at this point
Copy the full SHA df22aa7View commit details -
Modified Peng-Robinson to test file to read phase from
thermo-models.yaml
Configuration menu - View commit details
-
Copy full SHA for 891ce6c - Browse repository at this point
Copy the full SHA 891ce6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8d7ee0 - Browse repository at this point
Copy the full SHA f8d7ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fe68b6 - Browse repository at this point
Copy the full SHA 4fe68b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcab6f2 - Browse repository at this point
Copy the full SHA fcab6f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffaaa77 - Browse repository at this point
Copy the full SHA ffaaa77View commit details -
Indentation changes in the PengRobinson.cpp
Co-authored-by: Ray Speth <speth@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 5d67a47 - Browse repository at this point
Copy the full SHA 5d67a47View commit details -
Update include/cantera/thermo/PengRobinson.h
Co-authored-by: Ray Speth <speth@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 59e13a8 - Browse repository at this point
Copy the full SHA 59e13a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8562bb7 - Browse repository at this point
Copy the full SHA 8562bb7View commit details -
Removed the changes for P-R EoS model in ctml_writer.py, since the
CTI/XML option is not implemented for Peng-Robinson EoS model.
Configuration menu - View commit details
-
Copy full SHA for fdfcc31 - Browse repository at this point
Copy the full SHA fdfcc31View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfaae6d - Browse repository at this point
Copy the full SHA bfaae6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71f124e - Browse repository at this point
Copy the full SHA 71f124eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e46979 - Browse repository at this point
Copy the full SHA 2e46979View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61d1fe4 - Browse repository at this point
Copy the full SHA 61d1fe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e81424 - Browse repository at this point
Copy the full SHA 0e81424View commit details -
Configuration menu - View commit details
-
Copy full SHA for b57740a - Browse repository at this point
Copy the full SHA b57740aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2cd14d - Browse repository at this point
Copy the full SHA f2cd14dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1ad7e - Browse repository at this point
Copy the full SHA 7d1ad7eView commit details -
Changed the function name 'pressureDerivatives' to
'calculatePressureDerivatives'
Configuration menu - View commit details
-
Copy full SHA for 137deb6 - Browse repository at this point
Copy the full SHA 137deb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 157291d - Browse repository at this point
Copy the full SHA 157291dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46f3115 - Browse repository at this point
Copy the full SHA 46f3115View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21bd4e0 - Browse repository at this point
Copy the full SHA 21bd4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 131fa19 - Browse repository at this point
Copy the full SHA 131fa19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e83651 - Browse repository at this point
Copy the full SHA 5e83651View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91cc8df - Browse repository at this point
Copy the full SHA 91cc8dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0687e6d - Browse repository at this point
Copy the full SHA 0687e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b2e0f8 - Browse repository at this point
Copy the full SHA 5b2e0f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76bb6bf - Browse repository at this point
Copy the full SHA 76bb6bfView commit details -
Cleaning up functions to calculate critical properties in Redlich-Kwong
and Peng-Robinson classes 1. Declared calcCriticalConditions() as virtual in MixtureFugacityTP class. 2. Moved all functions to calculate critical properties to the parent (MixtureFugacityTP) class.
Configuration menu - View commit details
-
Copy full SHA for 5d3e6df - Browse repository at this point
Copy the full SHA 5d3e6dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a180bab - Browse repository at this point
Copy the full SHA a180babView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e142e4 - Browse repository at this point
Copy the full SHA 1e142e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d620b1a - Browse repository at this point
Copy the full SHA d620b1aView commit details -
Reading w_ac (acentric factor) with a more useful message that will
point to the source of the error accurately
Configuration menu - View commit details
-
Copy full SHA for 6823f68 - Browse repository at this point
Copy the full SHA 6823f68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a7f2b2 - Browse repository at this point
Copy the full SHA 6a7f2b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 666f285 - Browse repository at this point
Copy the full SHA 666f285View commit details -
Removing redundant _updateStateThermo() call from thermodynamic
calculations and also rebasing with cantera/main
Configuration menu - View commit details
-
Copy full SHA for 404a5f7 - Browse repository at this point
Copy the full SHA 404a5f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ea8da6 - Browse repository at this point
Copy the full SHA 4ea8da6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9508428 - Browse repository at this point
Copy the full SHA 9508428View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e3fb4c - Browse repository at this point
Copy the full SHA 5e3fb4cView commit details
Commits on Mar 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7fee130 - Browse repository at this point
Copy the full SHA 7fee130View commit details
Commits on Mar 21, 2021
-
Update include/cantera/thermo/PengRobinson.h
Co-authored-by: Ray Speth <speth@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 52e2212 - Browse repository at this point
Copy the full SHA 52e2212View commit details -
Update include/cantera/thermo/PengRobinson.h
Co-authored-by: Ray Speth <speth@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 67f22f6 - Browse repository at this point
Copy the full SHA 67f22f6View commit details -
Moving declaration of the protected variable m_pp from MixtureFugacity
class to the PengRobinson class
Configuration menu - View commit details
-
Copy full SHA for 4e07743 - Browse repository at this point
Copy the full SHA 4e07743View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b14db5 - Browse repository at this point
Copy the full SHA 6b14db5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c766a9d - Browse repository at this point
Copy the full SHA c766a9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb7386f - Browse repository at this point
Copy the full SHA fb7386fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec17b30 - Browse repository at this point
Copy the full SHA ec17b30View commit details
Commits on Apr 14, 2021
-
Update src/thermo/PengRobinson.cpp
Co-authored-by: Ray Speth <speth@mit.edu>
Configuration menu - View commit details
-
Copy full SHA for 1f5dbe7 - Browse repository at this point
Copy the full SHA 1f5dbe7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1539bd1 - Browse repository at this point
Copy the full SHA 1539bd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f0adc6 - Browse repository at this point
Copy the full SHA 8f0adc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d17641c - Browse repository at this point
Copy the full SHA d17641cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0dd0c0 - Browse repository at this point
Copy the full SHA a0dd0c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2478999 - Browse repository at this point
Copy the full SHA 2478999View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f9a65 - Browse repository at this point
Copy the full SHA 95f9a65View commit details -
Configuration menu - View commit details
-
Copy full SHA for dee71c1 - Browse repository at this point
Copy the full SHA dee71c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for aef53e5 - Browse repository at this point
Copy the full SHA aef53e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f934e50 - Browse repository at this point
Copy the full SHA f934e50View commit details -
Configuration menu - View commit details
-
Copy full SHA for e835d17 - Browse repository at this point
Copy the full SHA e835d17View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ea6496 - Browse repository at this point
Copy the full SHA 2ea6496View commit details -
Co-authored-by: Bryan W. Weber <bryan.w.weber@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ffafe40 - Browse repository at this point
Copy the full SHA ffafe40View commit details -
Co-authored-by: Bryan W. Weber <bryan.w.weber@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 228d802 - Browse repository at this point
Copy the full SHA 228d802View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9789555 - Browse repository at this point
Copy the full SHA 9789555View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5d4061 - Browse repository at this point
Copy the full SHA c5d4061View commit details
Commits on Apr 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 88a10c0 - Browse repository at this point
Copy the full SHA 88a10c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f66ce - Browse repository at this point
Copy the full SHA d0f66ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for f892c20 - Browse repository at this point
Copy the full SHA f892c20View commit details
Commits on Apr 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a9e8c4d - Browse repository at this point
Copy the full SHA a9e8c4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a7a938 - Browse repository at this point
Copy the full SHA 5a7a938View commit details