Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation corrections at xml.h #636

Merged
merged 2 commits into from
Jun 8, 2019

Conversation

ThanasisMattas
Copy link
Contributor

@ThanasisMattas ThanasisMattas commented May 3, 2019

1st commit: Some documentation corrections at xml.h

2nd commit: Rearrangement of methods to aid reading xml.cpp parallel to xml.h .

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #636 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   68.54%   68.53%   -0.01%     
==========================================
  Files         363      363              
  Lines       39978    39978              
==========================================
- Hits        27401    27400       -1     
- Misses      12577    12578       +1
Impacted Files Coverage Δ
include/cantera/base/xml.h 100% <ø> (ø) ⬆️
src/base/xml.cpp 72.8% <100%> (ø) ⬆️
src/transport/GasTransport.cpp 90.77% <0%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f078f53...a97831e. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is 75.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   68.53%   68.53%           
=======================================
  Files         368      368           
  Lines       40027    40027           
=======================================
  Hits        27434    27434           
  Misses      12593    12593
Impacted Files Coverage Δ
include/cantera/base/xml.h 100% <ø> (ø) ⬆️
src/base/xml.cpp 72.8% <75.47%> (ø) ⬆️
src/transport/GasTransport.cpp 90.98% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d62f3b...172fa72. Read the comment docs.

@speth speth merged commit 6a42e59 into Cantera:master Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants