Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property updates in BinarySolutionTabulatedThermo #606

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Fix property updates in BinarySolutionTabulatedThermo #606

merged 3 commits into from
Mar 7, 2019

Commits on Mar 5, 2019

  1. [Thermo] Fix overriding of IdealSolidSolnPhase::_updateThermo 

    Since IdealSolidSolnPhase::_updateThermo wasn't a virtual method, and
the signatures didn't match (const vs non-const), calls to this method
from IdealSolidSolnPhase weren't being overridden by
BinarySolutionTabulatedThermo::_updateThermo as expected.
    @speth
    speth committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    0b3a150 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. [Thermo] Fix BinarySolutionTabulatedThermo updates when only T changes 

    In the case where temperature changes but the mole fractions are the same, we
still need to apply the enthalpy and entropy offsets to the tabulated species.
    @speth
    speth committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    af58f91 View commit details
    Browse the repository at this point in the history

  2. [Thermo] Fix BinarySolutionTabulatedThermo initial mole fraction thermo 

    The value of m_xlast should only be set to a valid value by _updateThermo,
after it has calculated values for the tabulated enthalpy and entropy.
    @speth
    speth committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    3c97fa0 View commit details
    Browse the repository at this point in the history