Fix Chebyshev rate constant when using local quantity units #600
Conversation
speth
force-pushed
the
fix-chebyshev-units
branch
from
da1c3e0
to
815a038
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 68.5% 68.51% +<.01%
==========================================
Files 363 363
Lines 39957 39959 +2
==========================================
+ Hits 27374 27376 +2
Misses 12583 12583
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 68.5% 68.51% +<.01%
==========================================
Files 363 363
Lines 39957 39959 +2
==========================================
+ Hits 27374 27376 +2
Misses 12583 12583
Continue to review full report at Codecov.
|
|
Hey @speth, just curious what you changed to fix the previous CI errors so I can learn from it 😄 |
|
The first version of this didn't update all of the affected tests. I hadn't noticed the failure because I was only running a subset of the test suite locally. |
interfaces/cython/cantera/ck2cti.py
Outdated
| @@ -65,6 +65,8 @@ | |||
| 'KJOULES/MOL': 'kJ/mol', | |||
| 'KJOULES/MOLE': 'kJ/mol'} | |||
|
|
|||
| Avogadro = 6.02214129e23 # in molec/mol | |||
There was a problem hiding this comment.
Can you document where this number comes from? For instance, it is different from the CODATA value: https://physics.nist.gov/cgi-bin/cuu/Value?na
There was a problem hiding this comment.
It is the 2010 CODATA value, consistent with the value in ct_defs.h.
Since the leading Chebyshev coefficient has effective units like log(cm^3/kmol), it needs to be converted directly to the default units of the CTI file. Analogous to the fix for PLOG reactions in Cantera#435.
speth
force-pushed
the
fix-chebyshev-units
branch
from
815a038
to
4c28802
Compare
Since the leading Chebyshev coefficient has effective units like log(cm^3/kmol), it needs to be converted directly to the default units of the CTI file.
Analogous to the fix for PLOG reactions in #435.