Fix issues with input files derived from GRI 3.0 #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XML versions of these files that are actually installed/used are the ones generated during the build process from their CTI equivalents.
The old (C++) ck2cti program unnecessarily rounded some species transport coefficients. This updates the coefficients in the input files derived from GRI 3.0, and updates the test comparisons for affected tests.
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 68.42% 68.42% +<.01%
==========================================
Files 360 360
Lines 39791 39791
==========================================
+ Hits 27226 27227 +1
+ Misses 12565 12564 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old (C++) ck2cti program unnecessarily rounded some species transport coefficients. This updates the coefficients in the input files derived from GRI 3.0, and updates the test comparisons for affected tests. The changes in species diffusion coefficients are on the order of 0.2% or less.
Also, this deletes some redundant XML files from the source tree, to avoid having to update them as well.