Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add solvePseudoSteadyStateProblem() in cython interface #592

Merged
merged 5 commits into from
Feb 11, 2019
Merged

Add solvePseudoSteadyStateProblem() in cython interface #592

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
605f62a
Add solvePseudoSteadyStateProblem to cython interface
lavdwall Feb 2, 2019
9009625
Add solvePseudoSteadyStateProblem to cython interface
lavdwall Feb 2, 2019
40cf73f
Merge pull request #2 from lavdwall/patch-2
lavdwall Feb 2, 2019
535b8e2
Merge pull request #3 from lavdwall/patch-1
lavdwall Feb 2, 2019
a1a814d
Update description
lavdwall Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions interfaces/cython/cantera/_cantera.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ cdef extern from "cantera/kinetics/Kinetics.h" namespace "Cantera":
cdef extern from "cantera/kinetics/InterfaceKinetics.h":
cdef cppclass CxxInterfaceKinetics "Cantera::InterfaceKinetics":
void advanceCoverages(double) except +translate_exception
void solvePseudoSteadyStateProblem() except +translate_exception


cdef extern from "cantera/transport/TransportBase.h" namespace "Cantera":
Expand Down
6 changes: 6 additions & 0 deletions interfaces/cython/cantera/kinetics.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,12 @@ cdef class InterfaceKinetics(Kinetics):
coverages for a specified amount of time.
"""
(<CxxInterfaceKinetics*>self.kinetics).advanceCoverages(dt)

def advance_coverages_to_steady_state(self):
"""
This method advances the surface coverages to (pseudo) steady state.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this comes from the name of the underlying method, but can you either explain what "pseudo" means here, or remove it from the description, depending on what you think makes more sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is OK just to remove it from the description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you push a revised version of the PR, then?

"""
(<CxxInterfaceKinetics*>self.kinetics).solvePseudoSteadyStateProblem()

def phase_index(self, phase):
"""
Expand Down