Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code deprecated in Cantera 2.4.0 #580

Merged
merged 3 commits into from
Dec 14, 2018

Conversation

speth
Copy link
Member

@speth speth commented Dec 4, 2018

Remove code deprecated and marked for removal in Cantera 2.4. Includes the following classes: AxiStagnFlow and FreeFlame (now combined in StFlow), AqueousKinetics, Adsorbate, MetalSHEelectrons, MineralEQ3, MixedSolventElectrolyte, MolarityIonicVPSSTP, PhaseCombo_Interaction, LTPspecies, LiquidTranInteraction, LiquidTransport, LiquidTransportData, LiquidTransportParams, SimpleTransport, SolidTransport, SolidTransportData, Tortuosity.

Also adds new deprecations for some rarely-used functions defined in utilities.h, including sum_each, scatter_copy, sum_xlogx, etc.

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #580 into master will increase coverage by 3.62%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   64.01%   67.63%   +3.62%     
==========================================
  Files         388      362      -26     
  Lines       41410    38390    -3020     
==========================================
- Hits        26507    25964     -543     
+ Misses      14903    12426    -2477
Impacted Files Coverage Δ
include/cantera/transport/TransportBase.h 100% <ø> (ø) ⬆️
src/thermo/MultiSpeciesThermo.cpp 70.29% <ø> (+3.31%) ⬆️
include/cantera/kinetics/ThirdBodyCalc.h 100% <ø> (ø) ⬆️
src/thermo/MolalityVPSSTP.cpp 76.77% <ø> (+0.85%) ⬆️
include/cantera/thermo/LatticePhase.h 100% <ø> (ø) ⬆️
include/cantera/transport/WaterTransport.h 33.33% <ø> (ø) ⬆️
include/cantera/thermo/Phase.h 100% <ø> (ø) ⬆️
src/thermo/ThermoFactory.cpp 76.19% <ø> (-0.45%) ⬇️
src/thermo/ThermoPhase.cpp 65.75% <ø> (+1.03%) ⬆️
include/cantera/transport/TransportFactory.h 100% <ø> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d9b64...d880e16. Read the comment docs.

@speth speth merged commit 19577ab into Cantera:master Dec 14, 2018
@speth speth deleted the remove-deprecated-2.4 branch January 8, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant