-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ion gas transport fix #568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 64.92% 64.92% +<.01%
==========================================
Files 386 386
Lines 40800 40804 +4
==========================================
+ Hits 26489 26493 +4
Misses 14311 14311
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spelling error noted below is presumably all that is preventing the Python method from working. After fixing that, I'm assuming you can get the new tests in working order.
@@ -858,6 +858,7 @@ cdef extern from "cantera/cython/wrappers.h": | |||
cdef void tran_getMixDiffCoeffsMole(CxxTransport*, double*) except +translate_exception | |||
cdef void tran_getThermalDiffCoeffs(CxxTransport*, double*) except +translate_exception | |||
cdef void tran_getSpeciesViscosities(CxxTransport*, double*) except +translate_exception | |||
# cdef void tran_getMobilities(CxxTransport*, double*) except +translate_excepttion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
translate_exception
is misspelled.
45bfe87
to
b1e8359
Compare
Thank you. It is hard to spot this kind of typo. |
Also add test_mobility and test_update_temperature to TestIonTransport
b1e8359
to
8138fbe
Compare
No problem, and thanks for the updates. I made a few small changes to the tests -- as written, they relied on the tests executing in the order written, which is not guaranteed. |
This PR is for some issues found in IonGasTransport.
Changes proposed in this pull request: