Ion gas transport #552
Merged
Ion gas transport #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
==========================================
+ Coverage 64.91% 64.94% +0.03%
==========================================
Files 386 386
Lines 40787 40859 +72
==========================================
+ Hits 26475 26537 +62
- Misses 14312 14322 +10
Continue to review full report at Codecov.
|
speth
requested changes
Sep 21, 2018
src/transport/IonGasTransport.cpp
Outdated
| vector_fp temp{300.0, 400.0, 500.0, 600.0, 800.0, 1000.0, | ||
| 1200.0, 1500.0, 2000.0, 2500.0, 3000.0, 4000.0}; | ||
| vector_fp om11_O2{120.0, 107.0, 98.1, 92.1, 83.0, 77.0, | ||
| 72.6, 67.9, 62.7, 59.3, 56.7, 53.8}; |
There was a problem hiding this comment.
These arrays can be constant and fixed size, e.g. const double temp[] = {300.0, ...};
src/transport/IonGasTransport.cpp
Outdated
| // set up O2/O2- collision integral [A^2] | ||
| // Data taken from: | ||
| // Prager, Jens. Modeling and simulation of charged species in | ||
| // lean methane-oxygen flames. Diss. 2005. Page 104. |
There was a problem hiding this comment.
I think the better place to document this (in full) would be in the docstring for the IonTransport class, so that this information appears in the documentation, then here you can just write that these are from "Prager (2005)".
BangShiuh
force-pushed
the
ionGasTransport
branch
from
09f02ae
to
da2820f
Compare
speth
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an update to ionGasTransport. The experimental data of collision integral of O2/O2- is used instead of stockmayer-(n,6,4) model due to resonant charge transfer effect.