-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: hydrogen combustion example blank page removed #518
Conversation
This is being tracked in #313, where the solution is to add the example rather than removing the page |
could I be shown another example in the doc or elsewhere to know in what specific format is the example to be filled? |
The example in question is on pg. 55 of the PDF linked in #313. Other examples can be found in https://github.com/Cantera/cantera/tree/master/interfaces/cython/cantera/examples for Python and https://github.com/Cantera/cantera/tree/master/samples/matlab for Matlab. Note that the script in the PDF is a Matlab script, but we would prefer to have either Python or both Python and Matlab. You can also directly use the |
I'm inclined to accept the solution of just removing the blank page, since it's not clear that those examples really belong as part of the CTI documentation anyway. The only change needed to this PR is that the entry in |
combustion example reference from the file has been removed.
combustion example reference from cti/ index.rst has been removed. |
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 64.78% 64.78% +<.01%
==========================================
Files 383 383
Lines 40734 40736 +2
==========================================
+ Hits 26390 26392 +2
Misses 14344 14344
Continue to review full report at Codecov.
|
Changes proposed in this pull request:
that has been removed.