Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in duplicate reaction checks #468

Merged
merged 2 commits into from
Aug 2, 2017
Merged

Conversation

speth
Copy link
Member

@speth speth commented Aug 2, 2017

Fix two problems identified in the duplicate reaction checks from a mechanism provided by @rwest .

In the first, we were comparing each reaction against the wrong reaction (i.e. not ones that we had identified as having the same set of species participating) causing a lot of unmarked duplicates to slip through.

In the second, reaction pairs like

OH* -> OH
OH* + CO2 -> OH + CO2

were mistakenly being flagged as duplicates.

@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #468 into master will decrease coverage by <.01%.
The diff coverage is 64.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
- Coverage   58.33%   58.32%   -0.01%     
==========================================
  Files         386      386              
  Lines       42362    42364       +2     
  Branches     7260     7262       +2     
==========================================
- Hits        24712    24710       -2     
  Misses      15464    15464              
- Partials     2186     2190       +4
Impacted Files Coverage Δ
src/kinetics/Kinetics.cpp 76.74% <64.7%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45891a2...c6a45af. Read the comment docs.

@speth speth merged commit 4c489c1 into Cantera:master Aug 2, 2017
@speth speth deleted the duplicaterxns branch August 2, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant