Fixed dummy element entry in elements.xml. #363
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elements.xml allowed for the creation of a dummy element but the dummy element tag was incomplete. Trying to use the dummy element caused cantera to throw an exception:
CanteraError thrown by LookupWtElements:
element not found
I updated the dummy element tag and the exception is no longer thrown.
Another strange behavior is that if the user sets atomicWt = "0.0" in the dummy element, then cantera throws the same exception as before. Right now, I set atomicWt = "1.0E-16" which works. Maybe cantera is trying to require positive atomic weights in which case a different error message may be more informative.