Revised twin flame #356
Closed
Revised twin flame #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second issue is fixed by 6b588c5. Not actually a numerical issue. |
…ks with cantera2.3.0a2
|
Based on previous comment, I explicitly added reference to select mixture-averaged model. The example now works with GRI 3.0 |
| @@ -1,20 +1,59 @@ | |||
| # coding: utf-8 | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
Is there a reason for removing this summary?
There was a problem hiding this comment.
Accidentally omitted. Reinserted in e738001
…ed code in comments
| # Use mixture-averaged properties | ||
| oppFlame.transport_model = 'Mix' | ||
| # Uncomment this line to use a Multi-component formulation. Default is mixture-averaged | ||
| #oppFlame.transport_model = 'Mix' |
There was a problem hiding this comment.
Should this say 'Multi' to match the comment? Or should the comment be changed?
There was a problem hiding this comment.
Thanks for the catch. Changed in 833e850
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems with the existing example (premixed_counterflow_twin_flame.py)
In this commit, I fixed the first problem. I checked it against the Smooke and Giovangigli mechanism for methane, for which this file works. I also tried lots of ways to curv, gradient, etc and various compositions, but gave up. Looks like a numerical (convergence) issue, but there is a good chance that the code will work with other mechanisms that do not ship with Cantera
Secondly, I added a function to compute the consumption speed, since this is a popular use for the twin flame solver. The integration is done using np.trapz, overriding the need for scipy.integrate.trapz as was done in the previous commit