Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old CVODE with submodule for current Sundials version #309

Merged
merged 4 commits into from
Nov 23, 2015
Merged

Replace old CVODE with submodule for current Sundials version #309

merged 4 commits into from
Nov 23, 2015

Conversation

speth
Copy link
Member

@speth speth commented Nov 13, 2015

  • Sensitivity calculations are always available
  • The max_err_test_fails option is always available
  • There is no special case just for the old CVODE API (i.e CVodeInt is now gone)
  • Separates more external code from the Cantera repository
  • Should resolve 2.2.0 installation with MATLAB fails runCanteraTests.m.passed #285 (if we always bundle Sundials inside the Cantera library when building the Matlab toolbox)
  • Users don't need to install Sundials if they're only using through Cantera

@bryanwweber bryanwweber mentioned this pull request Nov 18, 2015
Closed
@speth speth merged commit 59f8fbc into Cantera:master Nov 23, 2015
@speth speth deleted the sundials-submodule branch December 15, 2015 16:55
@speth speth mentioned this pull request Nov 29, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.2.0 installation with MATLAB fails runCanteraTests.m.passed
1 participant
@speth