Fix Matlab PureFluid functions and documentation #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First commit is fine, and I can confirm that it works. Worth mentioning that it resolves #299 in the commit message. For the second commit, I think the summary lines for each function should also be updated to indicate that the state is e.g. temperature and vapor fraction. |
Fix the setState_satLiquid and setState_satVapor functions so that they call the main set method instead of the underlying C++ layer. Resolves Cantera#299.
Correct the documentation to clarify that a vector must be passed in to these functions, not a single value.
bryanwweber
force-pushed
the
fix-matlab-purefluid-functions
branch
from
8508dad
to
0be9e7e
Compare
|
@speth I updated the docs to address your comment. Rather than put the details in the summary line, to keep it under 80 characters, I added a bit below the function definition. |
|
Great. Feel free to push this to master. |
bryanwweber
added a commit
that referenced
this pull request
Oct 24, 2015
Fix Matlab PureFluid functions and documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #299