Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfault in deprecated newPhase factory function #1600

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Fix segfault in deprecated newPhase factory function #1600

merged 1 commit into from
Aug 22, 2023

Commits on Aug 22, 2023

  1. [Thermo] Fix segfault in deprecated newPhase factory function 

    The shared_ptr goes out of scope at the end of the function,
deleting the held ThermoPhase right as it's returned.

Erroneous behavior introduced in f3e840d (Cantera#1448).
    @speth
    speth committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9b55c1a View commit details
    Browse the repository at this point in the history