Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCons] Require minimum HighFive version #1529

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jul 5, 2023

Changes proposed in this pull request

Require HighFive>=2.5

If applicable, fill in the issue number this pull request is fixing

Closes #1527

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1529 (86a6bbe) into main (6f2c665) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
+ Coverage   70.50%   70.51%   +0.01%     
==========================================
  Files         376      376              
  Lines       59075    59075              
  Branches    21219    21219              
==========================================
+ Hits        41649    41656       +7     
+ Misses      14348    14341       -7     
  Partials     3078     3078              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth speth merged commit f89efe8 into Cantera:main Jul 5, 2023
@ischoegl ischoegl deleted the fix-1527 branch July 5, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault with HighFive 2.4.1 and older
2 participants