-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out thermo consistency tests #1501
Conversation
afdce7f
to
477f245
Compare
This improves the accuracy of derived properties calculated using finite differences.
a3a32c1
to
6280677
Compare
Codecov Report
@@ Coverage Diff @@
## main #1501 +/- ##
==========================================
+ Coverage 69.48% 69.77% +0.28%
==========================================
Files 377 377
Lines 58011 58011
Branches 20695 20695
==========================================
+ Hits 40311 40479 +168
+ Misses 14748 14577 -171
- Partials 2952 2955 +3
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Failing test cases documented in Cantera#1500
6280677
to
b1fd213
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @speth - apart from the new Debye-Huckel tests, I definitely appreciate separating consistency from other thermo tests, which will make the latter much more tractable.
Changes proposed in this pull request
Checklist
scons build
&scons test
) and unit tests address code coverage