Fix clash of names with upstream function

[ischoegl]

HighFive 2.7.0 introduces h5py-style support for booleans, which is close to identical with what was already implemented in Storage.cpp. HighFive uses the exact same name for a new create_enum_boolean function, which clashes with an existing local function in Storage.cpp, causing CI failures when conda packages highfive with versions 2.7.0 and newer are used.

The resolution is to use the full name for older versions of HighFive (2.7.0 and older), while using HighFive's implementation for boolean support for HighFive 2.7.1 and newer (this avoids a change of their API from 2.7.0 to 2.7.1). For the time being, the git submodule remains on 2.6.2, while conda will grab the newest package available.

Other updates:

• use system installation of HighFive by default and other SCons logic fixes
• detect and display HighFive version

See BlueBrain/HighFive#713 and BlueBrain/HighFive#724

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Merging #1471 (97a6c11) into main (1f1751b) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
+ Coverage   70.04%   70.05%   +0.01%     
==========================================
  Files         377      377              
  Lines       57772    57773       +1     
  Branches    19406    19406              
==========================================
+ Hits        40465    40473       +8     
+ Misses      14746    14739       -7     
  Partials     2561     2561              

Impacted Files	Coverage Δ
src/base/Storage.cpp	79.48% <80.00%> (+0.05%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ischoegl]

While this is ready for a review, I am leaving this in draft mode until HighFive 2.7.1 is released. The current CI failures on windows-2022 are caused by a known issue with conda's highfive package 2.7.0 for MSVC 14.1 that are presumably unrelated to Cantera. Edit: pinned conda’s highfive to older versions.

Update: while HighFive 2.7.1 is released (and is expected to fully resolve all issues), the conda packages aren’t generated/uploaded yet.

[ischoegl]

@speth ... as expected, HighFive 2.7.1 conda packages resolve the CI issues (other than #1473, which is separate).

[speth]

Thanks for finding the solution to this, @ischoegl -- the CI error messages definitely did not make it clear what was going wrong. I had some suggestions that I think will simplify the configuration checks a bit.

[ischoegl]

Thanks for finding the solution to this, @ischoegl -- the CI error messages definitely did not make it clear what was going wrong.

I guess I need to give a shoutout to folks over at the HighFive project, who were extremely helpful and responsive in the debugging effort.

Other than that, I rebased and addressed three of the four suggestions. For the last one, I no longer rewrite the file, but am not sure how to move things out of SConstruct without major overhauls of the scons workflow.

[ischoegl]

@speth ... thanks for the suggestion. I believe that everything is taken care of at this point.

I submitted a minor PR #1477 that could be adopted before the version bump, but it's not a major issue (it's mostly about updating annoying formatting for something that I've been working on).

[speth]

Thanks, @ischoegl, this looks good to me. Just one small simplification left, I think.

[ischoegl]

@speth ... could you re-approve? (fixing the last item dismissed your approval)