-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues identified by _GLIBCXX_ASSERTIONS and various build warnings #1441
Conversation
Starting in macOS 13.2, the use of sprintf started generating deprecation warnings, even though it's not deprecated by the C++ standard.
7fd9fdc
to
270482f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1441 +/- ##
=======================================
Coverage 70.92% 70.92%
=======================================
Files 369 369
Lines 55227 55232 +5
Branches 18194 18196 +2
=======================================
+ Hits 39171 39176 +5
Misses 13595 13595
Partials 2461 2461
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Setuptools started giving the warning: "Installing 'cantera.test' as data is deprecated, please list it in `packages`." for the data, test, and examples directories.
270482f
to
ec523de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes! While the ANOTE
work-arounds point to a need for a better logging solution long-term, the changes look good to me.
Changes proposed in this pull request
_GLIBCXX_ASSERTIONS
macro definedIf applicable, fill in the issue number this pull request is fixing
Closes #1430
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage