-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some minor issues #1437
Fix some minor issues #1437
Conversation
Addendum to Cantera#1434; update ensures that checks are run for all tests of the test suite that involve pytest.
Codecov Report
@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
+ Coverage 70.91% 70.92% +0.01%
==========================================
Files 369 369
Lines 55229 55229
Branches 18194 18194
==========================================
+ Hits 39165 39173 +8
+ Misses 13602 13595 -7
+ Partials 2462 2461 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can I also suggest a bump to |
It's true that we should bump soon; I was hoping to get #1426 in before, but I know that the review of this one requires some bandwidth. |
@speth ... just added the suggested version bump. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ischoegl. This looks good to me.
Changes proposed in this pull request
scons test
triggers check forpytest
(see [Scons] Remove "install" target from "check_for_pytest" #1434)AUTHORS
3.0.0a4
Checklist
scons build
&scons test
) and unit tests address code coverage