Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some minor issues #1437

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Fix some minor issues #1437

merged 4 commits into from
Feb 16, 2023

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Feb 15, 2023

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Addendum to Cantera#1434; update ensures that checks are run for all tests of
the test suite that involve pytest.
AUTHORS Show resolved Hide resolved
@ischoegl ischoegl marked this pull request as ready for review February 15, 2023 18:13
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #1437 (0b377c3) into main (ba76a7b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   70.91%   70.92%   +0.01%     
==========================================
  Files         369      369              
  Lines       55229    55229              
  Branches    18194    18194              
==========================================
+ Hits        39165    39173       +8     
+ Misses      13602    13595       -7     
+ Partials     2462     2461       -1     
Impacted Files Coverage Δ
interfaces/cython/cantera/ck2yaml.py 88.96% <ø> (ø)
interfaces/cython/cantera/cti2yaml.py 77.51% <ø> (ø)
interfaces/cython/cantera/ctml2yaml.py 84.50% <ø> (ø)
src/base/stringUtils.cpp 80.62% <0.00%> (+0.77%) ⬆️
...terfaces/dotnet/Cantera/src/Interop/InteropUtil.cs 69.62% <0.00%> (+8.86%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@speth
Copy link
Member

speth commented Feb 15, 2023

Can I also suggest a bump to 3.0.0a4? It's been 5 months and 200 commits since the last one. I meant to do this in my last PR but forgot.

@ischoegl
Copy link
Member Author

ischoegl commented Feb 16, 2023

Can I also suggest a bump to 3.0.0a4? It's been 5 months and 200 commits since the last one. I meant to do this in my last PR but forgot.

It's true that we should bump soon; I was hoping to get #1426 in before, but I know that the review of this one requires some bandwidth.

@ischoegl ischoegl requested a review from a team February 16, 2023 01:42
@ischoegl
Copy link
Member Author

ischoegl commented Feb 16, 2023

@speth ... just added the suggested version bump.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ischoegl. This looks good to me.

@speth speth merged commit 3d43413 into Cantera:main Feb 16, 2023
@ischoegl ischoegl deleted the fix-1434 branch March 26, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants