-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link Python module to Cantera shared library #1429
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d3d5d62 - Browse repository at this point
Copy the full SHA d3d5d62View commit details -
Configuration menu - View commit details
-
Copy full SHA for a31d1f3 - Browse repository at this point
Copy the full SHA a31d1f3View commit details
Commits on Feb 2, 2023
-
Move some function definitions out of header files
This reduces the set of functions that need to be exported from the shared library, which includes methods called from inlined functions defined in header files.
Configuration menu - View commit details
-
Copy full SHA for 4e6ad9d - Browse repository at this point
Copy the full SHA 4e6ad9dView commit details -
Fix compilation failures with PCH and Eigen
Compilation of polyfit.cpp was failing with GCC on some systems with the error: "second argument to '__builtin_prefetch' must be a constant"
Configuration menu - View commit details
-
Copy full SHA for 9341f34 - Browse repository at this point
Copy the full SHA 9341f34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 523be4e - Browse repository at this point
Copy the full SHA 523be4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for caed5c0 - Browse repository at this point
Copy the full SHA caed5c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35d4cf2 - Browse repository at this point
Copy the full SHA 35d4cf2View commit details -
[SCons] Compile using C++17 standard
This is a prerequisite to using Boost.DLL with the std::filesystem library.
Configuration menu - View commit details
-
Copy full SHA for fb5948f - Browse repository at this point
Copy the full SHA fb5948fView commit details -
Introduce cantera_python shim and load only when needed
This eliminates the need to directly link the Cantera shared library or Cantera applications to libpython.
Configuration menu - View commit details
-
Copy full SHA for 783129b - Browse repository at this point
Copy the full SHA 783129bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09db742 - Browse repository at this point
Copy the full SHA 09db742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8748dc0 - Browse repository at this point
Copy the full SHA 8748dc0View commit details -
Bump vendored fmt library to version 9.1.0
This version properly exports all necessary DLL symbols, eliminating the need to embed it separately in the Cython module.
Configuration menu - View commit details
-
Copy full SHA for 13da7c4 - Browse repository at this point
Copy the full SHA 13da7c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcd1a90 - Browse repository at this point
Copy the full SHA bcd1a90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 196d2a0 - Browse repository at this point
Copy the full SHA 196d2a0View commit details -
[SCons] Enforce minimum MACOS_DEPLOYMENT_TARGET
10.15 or newer is required for C++17 support
Configuration menu - View commit details
-
Copy full SHA for ffcd3e4 - Browse repository at this point
Copy the full SHA ffcd3e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c85e3 - Browse repository at this point
Copy the full SHA 71c85e3View commit details -
[SCons] Link to shared standard libraries with MinGW
This requires copying the relevant MinGW runtime libraries into the Python module.
Configuration menu - View commit details
-
Copy full SHA for b61e957 - Browse repository at this point
Copy the full SHA b61e957View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6ae255 - Browse repository at this point
Copy the full SHA a6ae255View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd80340 - Browse repository at this point
Copy the full SHA fd80340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d7d4e0 - Browse repository at this point
Copy the full SHA 1d7d4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9194a61 - Browse repository at this point
Copy the full SHA 9194a61View commit details -
[CI] Show timing info for brew install commands
Trying this to understand why this step can sometimes take upwards of 8 minutes.
Configuration menu - View commit details
-
Copy full SHA for 7688562 - Browse repository at this point
Copy the full SHA 7688562View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c5881e - Browse repository at this point
Copy the full SHA 3c5881eView commit details -
Add function to distinguish shared vs static linking at runtime
This is important because extensions can only be loaded correctly when Cantera is linked as a shared library.
Configuration menu - View commit details
-
Copy full SHA for 5f4eb5a - Browse repository at this point
Copy the full SHA 5f4eb5aView commit details -
Check for match between shared lib and Python module
When the Python module is linked to the Cantera shared library, it is possible that a user has multiple incompatible versions of the library installed. This checks that the Cantera version and Git commit are the same when importing the Python module, to avoid crashes or erroneous behavior due to ABI mismatches.
Configuration menu - View commit details
-
Copy full SHA for d6f1a79 - Browse repository at this point
Copy the full SHA d6f1a79View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0d6c9f - Browse repository at this point
Copy the full SHA f0d6c9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ec02f2 - Browse repository at this point
Copy the full SHA 3ec02f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dd702d - Browse repository at this point
Copy the full SHA 3dd702dView commit details