Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes / cleanup #1427

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Miscellaneous fixes / cleanup #1427

merged 10 commits into from
Jan 23, 2023

Conversation

speth
Copy link
Member

@speth speth commented Jan 22, 2023

Changes proposed in this pull request

This PR fixes a few small things that didn't seem worth independent PRs.

  • Match Sundials integer type in some functions (see discussion in Cantera 2.6.0: Multiple test failures if built with Lapack support and with Sundials 6.2.0 #1419, though I don't think this is a fix for that issue)
  • Fix handling of mechanism validation when minimal Python module is installed (validation needs to just be skipped, not cause an error)
  • Describe Peng-Robinson input parameters in YAML API docs
  • Deprecate Kinetics::surfacePhaseIndex in favor of Kinetics::reactionPhaseIndex
  • Deprecate unused ThermoPhase::getChemPotentials_RT method
  • Remove obsolete "friend" declaration referencing nonexistent SolveSS class
  • Remove references to "ASCII" input files
  • Fix various spelling errors

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Merging #1427 (ad3a627) into main (39d5f33) will increase coverage by 0.00%.
The diff coverage is 47.82%.

@@           Coverage Diff           @@
##             main    #1427   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files         378      378           
  Lines       55131    55134    +3     
  Branches    18158    18164    +6     
=======================================
+ Hits        38995    38999    +4     
  Misses      13626    13626           
+ Partials     2510     2509    -1     
Impacted Files Coverage Δ
include/cantera/cython/funcWrapper.h 74.56% <ø> (ø)
include/cantera/kinetics/BlowersMaselRate.h 95.34% <ø> (ø)
include/cantera/kinetics/ImplicitSurfChem.h 100.00% <ø> (ø)
include/cantera/kinetics/InterfaceRate.h 81.92% <ø> (ø)
include/cantera/kinetics/Kinetics.h 32.59% <ø> (-0.99%) ⬇️
include/cantera/kinetics/PlogRate.h 100.00% <ø> (ø)
include/cantera/oneD/Domain1D.h 82.35% <ø> (ø)
include/cantera/oneD/StFlow.h 95.53% <ø> (ø)
include/cantera/thermo/HMWSoln.h 50.00% <ø> (ø)
include/cantera/thermo/IdealGasPhase.h 92.30% <ø> (ø)
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ischoegl
ischoegl previously approved these changes Jan 23, 2023
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, thanks. Changes look goo do me!

@speth speth merged commit 8faf608 into Cantera:main Jan 23, 2023
@speth speth deleted the misc-fixups branch January 23, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants