-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various CI issues #1399
Fix various CI issues #1399
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1399 +/- ##
==========================================
- Coverage 71.03% 71.03% -0.01%
==========================================
Files 363 363
Lines 51898 51900 +2
Branches 17366 17369 +3
==========================================
+ Hits 36868 36869 +1
- Misses 12683 12684 +1
Partials 2347 2347
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
01c8e82
to
fbc93a8
Compare
@speth … thanks for addressing these! Regarding the remaining failing examples runners, I cherry-picked @bryanwweber’s fix to #1384 (which should be ready to merge). |
0f8b616
to
3cd4e0b
Compare
For some reason, setuptools thinks it needs to be able to find the user's home directory to build a wheel, but on Windows this relies on an environment variable (USERPROFILE) that we weren't by default passing in through SCons.
e794706
to
054fabb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes proposed in this pull request
Add testing of the .NET interface on all OSesdeferred for nowIf applicable, fill in the issue number this pull request is fixing
Closes #1397
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build
&scons test
) and unit tests address code coverage