Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of MoleReactor and ConstantPressureMoleReactor #1363

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Implementation of MoleReactor and ConstantPressureMoleReactor #1363

merged 3 commits into from
Sep 9, 2022

Commits on Sep 9, 2022

  1. Implements MoleReactor and ConstPressureMoleReactor, tests, and docs. 

    This commit implements MoleReactor and ConstPressureMoleReactor classes,
it adds the appropriate python interfaces for them, it also adds a test
comparing surface chemistry of mole reactors to traditional reactors.

test_component_names had a bug because the network was not initialized
so self.net.n_vars was 0 and the loop was never entered. Adding a line
to initialize the network reveal that the test failed for
IdealGasMoleReactor so the appropriate lines were added to fix it.

Add wrappers for Extensible...MoleReactor, update docs, comment fixes.
    @anthony-walker
    anthony-walker committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    76eca36 View commit details
    Browse the repository at this point in the history

  2. Updates to documentation 

    Co-authored-by: Ingmar Schoegl <ischoegl@lsu.edu>
    @anthony-walker @ischoegl
    anthony-walker and ischoegl committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    c8679bb View commit details
    Browse the repository at this point in the history

  3. Version documentation for MoleReactors

    @anthony-walker
    anthony-walker committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    bcd8124 View commit details
    Browse the repository at this point in the history