Add missing array properties to SolutionArray and FlameBase #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend test suite to check that all properties of the Solution class either return appropriate arrays in the FlameBase class or are specifically excluded.
Extend test suite to check that all properties of the Solution class either return appropriate arrays in the SolutionArray class or are specifically excluded.
Codecov Report
@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
+ Coverage 68.03% 68.15% +0.11%
==========================================
Files 327 327
Lines 42652 42658 +6
Branches 17180 17180
==========================================
+ Hits 29020 29074 +54
+ Misses 11345 11291 -54
- Partials 2287 2293 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
FlameBaseandSolutionArrayclasses. Most of these are the derivatives of the reaction rates / rates of progress, but there were a few others as well, such asFlameBase.mean_molecular_weightpropertys of theSolutionobject are extended to the corresponding array form in theFlameBaseandSolutionclasses, except for those that are specifically excluded. This will prevent new properties of theSolutionclass from being neglected in the future.equivalence_ratioproperty toCounterflowDiffusionFlameIf applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage