-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Transport updates #1327
Some Transport updates #1327
Conversation
025836b
to
798e10d
Compare
@speth / @bryanwweber ... this is a trivial PR - not sure how to avoid the apparent 'churn' (which really isn't there) due to renaming + recreating a rudimentary file with the old name for deprecation purposes. I tried this in separate commits before, but it doesn't appear to make any difference ... |
Codecov Report
@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
+ Coverage 67.19% 68.04% +0.85%
==========================================
Files 314 314
Lines 41905 42007 +102
Branches 16862 16880 +18
==========================================
+ Hits 28156 28582 +426
+ Misses 11518 11167 -351
- Partials 2231 2258 +27
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this annoying inconsistency, @ischoegl. I had just a few minor suggestions.
Also replace doublereal by double in Transport.h
b3441a9
to
b69c989
Compare
@speth ... thanks for the review! Changes are taken care of. |
Changes proposed in this pull request
The header
TransportBase.h
does not match the naming convention used for other fundamental headers, whileTransport.h
does (see, e.g. includes incore.h
introduced in #1238)cantera/include/cantera/core.h
Lines 12 to 15 in dceacdf
Also, streamline construction of
Transport
objects in Python.Checklist
scons build
&scons test
) and unit tests address code coverage