Fix compatibility with SCons 3.x #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'relpath' attribute was only introduced in SCons 4.2.0, which isn't available on all supported build environments (notably, Anaconda, which only has SCons 4.1.0). Fixes Cantera#1253
ischoegl
reviewed
Apr 30, 2022
ischoegl
previously approved these changes
Apr 30, 2022
|
Hmm, I thought that was a clever option, but I guess SCons 3.0.1 (and maybe all 3.x releases?) are not compatible with Python 3.10. I'll have to think about how to do this without bloating the set of CI cases any further. |
|
Well, based on the success of Ubuntu 20.04 (SCons 3.1.2) with Python 3.10, but not 18.04 (SCons 3.0.1), we can at least test that version. |
Make sure that we're continuing to test older but still supported versions of SCons.
speth
force-pushed
the
fix-1253-scons-relpath
branch
from
af2e991
to
cb03583
Compare
ischoegl
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'relpath' attribute was only introduced in SCons 4.2.0, which isn't available on all supported build environments (notably, Anaconda, which only has SCons 4.1.0).
If applicable, fill in the issue number this pull request is fixing
Fixes #1253
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage