Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing files in MSI #1241

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Fix missing files in MSI #1241

merged 1 commit into from
Apr 11, 2022

Conversation

speth
Copy link
Member

@speth speth commented Apr 11, 2022

Changes proposed in this pull request

  • Fix builds of the MSI installer so they actually contain the data files, samples, and Matlab toolbox

If applicable, fill in the issue number this pull request is fixing

Fixes problems introduced by some changes that were incorrectly modifying "prefix" and ignoring the stage directory when the stage directory was being specified internally by the SCons msi target rather than directly as a command line option.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@bryanwweber bryanwweber merged commit 6200ea0 into Cantera:main Apr 11, 2022
@speth speth deleted the fix-msi-files branch July 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants