Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-minimal installation issues #1240

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Fix python-minimal installation issues #1240

merged 3 commits into from
Apr 10, 2022

Conversation

speth
Copy link
Member

@speth speth commented Apr 10, 2022

Changes proposed in this pull request

  • Fix a couple issues with installation of the 'minimal' Python module
  • Bump version to 2.6.0b2 so we can get a full set of binaries including PyPI uploads

If applicable, fill in the issue number this pull request is fixing

Closes #1230

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Make the case where prefix is specified but python_prefix is not consistent
with how the full Python module is handled.

Fix a case where the minimal Python module could be installed to a directory
named literally 'python_prefix'.
@speth speth added the Python label Apr 10, 2022
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me … :shipit:

@speth speth merged commit f966864 into Cantera:main Apr 10, 2022
@speth speth deleted the bump-b2 branch July 23, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install procedure tries to uninstall Cantera-python version installed by system pkg manager
2 participants