Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building sdist and wheels and conda packages #1232

Merged
merged 8 commits into from
Mar 31, 2022
Merged

Fix building sdist and wheels and conda packages #1232

merged 8 commits into from
Mar 31, 2022

Commits on Mar 30, 2022

  1. [CI] Fix name of versioned Boost folder 

    We are now downloading 1.78 from jfrog. This has been working up to now
because the cache was available.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a64f215 View commit details
    Browse the repository at this point in the history

  2. [Cython] Allow instances of Path in write_yaml 

    YamlWriter.to_file() calls the C++ function after stringify-ing the
filename. This implicitly assumes that filename is a string. With this
change, filename can be either a string or an instance of pathlib.Path.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    dd716fe View commit details
    Browse the repository at this point in the history

  3. [Cython/Test] Fix tests writing to local directory 

    Tests that write data should do so in the test_work_path to avoid
polluting the user's current working directory and to avoid permission
errors if the current working directory is write-protected.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    82db426 View commit details
    Browse the repository at this point in the history

  4. [SCons] Fix config options for sdist 

    Some configuration options conflict with creating the sdist, or else are
just unnecessary. These options are checked and set to an appropriate
value if they aren't specified. The build now errors if incompatible
options are explicitly specified.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    7d751be View commit details
    Browse the repository at this point in the history

  5. [sdist] Fix platform-dependent sdist 

    The config.h file for Cantera needs to have certain values set on the
platform that will build/install Cantera, not the platform building the
sdist. These values are now added to the config.h.in template by
setup.py. Values that are not platform dependent are still handled by
SConscript when the sdist is generated.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    69ca6af View commit details
    Browse the repository at this point in the history

  6. [sdist] Reduce wheel size on Linux 

    Setuptools includes CFLAGS from when Python was built, which may include
the flag to add debug symbols. This dramatically inflates the size of
our wheels, so this change disables those symbols. We also exclude
source files from the built wheel. _cantera.cpp ends up being ~10 MB
uncompressed, so this is a signifcant savings as well. Overall, the
wheel goes from ~100 MB to ~5 MB.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b11e2cf View commit details
    Browse the repository at this point in the history

  7. Add a docstring to DefineDict in the sdist builder

    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a564868 View commit details
    Browse the repository at this point in the history

  8. [SCons] Only resolve prefix if stage_dir isn't set 

    Eager resolution of the prefix path to an absolute directory caused the
entire path to the prefix to be used under the stage_dir. As this breaks
the utility of stage_dir, the resolution is conditional on stage_dir
not being among the selected options.

Resolves build failures of the Conda package for Matlab.
    @bryanwweber
    bryanwweber committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    cfbbf0c View commit details
    Browse the repository at this point in the history