Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues - macOS rpath, wheel paths, missing pytest #1229

Merged
merged 10 commits into from
Mar 30, 2022

Commits on Mar 29, 2022

  1. [SCons] Fix linking to system version of fmt

    Eliminate duplication in building the list of external libraries
    to link to between SConstruct and src/SConscript.
    speth committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    27e4359 View commit details
    Browse the repository at this point in the history
  2. [SCons] Fix expected name of .whl file

    On macOS, sysconfig.get_platform() returns a string like
    'macosx-11.0-arm64', but the wheel filename will actually contain
    'macosx_11_0_arm64'.
    speth committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    dfb4caa View commit details
    Browse the repository at this point in the history
  3. [SCons] Determine name of macOS wheel in advance

    This prevents rebuilds of the wheel file every time 'scons build'
    is run because the actual wheel file doesn't match the expected name.
    
    Co-authored-by: Bryan W. Weber <bryan.w.weber@gmail.com>
    speth and bryanwweber committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    21e95e9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bace398 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    f7b7255 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e119193 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9885508 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    142107f View commit details
    Browse the repository at this point in the history
  5. Fix errors due to setuptools 61.0

    Something changed in setuptools that causes the old method of forcing
    platform-specific wheels to be built to break for certain configurations
    (specifically, Windows builds with Python 3.7). This alternative approach
    appears to be more robust.
    
    Also increase the logging from 'pip wheel' to help with debugging
    speth committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    75684b9 View commit details
    Browse the repository at this point in the history
  6. Eliminate NEEDS_GENERIC_TEMPL_STATIC_DECL

    The old way of handling declarations for static members of a
    template class was weird and required different implementations for
    different compilers. This approach is standards-conformant and works
    everywhere.
    speth committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    c00ded9 View commit details
    Browse the repository at this point in the history