-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shell] Deprecate shell setup scripts #1189
[Shell] Deprecate shell setup scripts #1189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. I think it would make sense to add context for what users should use instead.
Codecov Report
@@ Coverage Diff @@
## main #1189 +/- ##
==========================================
+ Coverage 65.39% 65.44% +0.05%
==========================================
Files 318 318
Lines 46109 46106 -3
Branches 19601 19604 +3
==========================================
+ Hits 30153 30175 +22
+ Misses 13452 13435 -17
+ Partials 2504 2496 -8
Continue to review full report at Codecov.
|
🎉 ... only thing remaining is to add some additional information on Cantera/enhancements#135 |
Yeah, I don't use those scripts, so I don't have any particular migration advice. I suppose the advice is "add the relevant parts to your |
On a related note, I believe this needs to be updated also (didn't realize this as I rarely ever install and thus never see this message): Lines 2018 to 2033 in 5b58690
|
Related to Cantera/enhancements#135
Checklist
scons build
&scons test
) and unit tests address code coverage