-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCons] Add info on git hash to SCons output #1176
Conversation
a83f522
to
7a77965
Compare
7a77965
to
ae316de
Compare
@bryanwweber ... thanks for the suggestion! |
Interestingly, the hash in the build logs is not the same as the commit shown in the PR here:
From https://github.com/Cantera/cantera/runs/4859330648?check_suite_focus=true#step:7:9 |
This is truly odd, as I’m just displaying a value that had existed before. No idea why the build creates a different hash (4fd09b3). |
PS: Pasting the hash actually resolved the riddle - the commit is a fix-up that was merged into what is now ae316de. I believe this is due to running |
The approach followed in |
🎉 FWIW, the merged build displays the correct hash, i.e.
so my interpretation is that the hash mismatch observed above is likely due to some GH internals. |
Changes proposed in this pull request
Add git hash at the beginning of the SCons build log:
Replaces #1175
Checklist
scons build
&scons test
) and unit tests address code coverage