Require pytest for test runners #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@speth and @bryanwweber … this should be it (last thing I added was a meaningful error with instructions if |
ischoegl
force-pushed
the
require-pytest
branch
from
64d78c5
to
f07ea4c
Compare
speth
approved these changes
Jan 16, 2022
There was a problem hiding this comment.
Looks good to me. I'll leave this open for the moment to see if @bryanwweber has any thoughts.
bryanwweber
approved these changes
Jan 16, 2022
| cantera_root = os.path.relpath(__file__).split(os.sep)[:-1] + ['..', '..'] | ||
| os.chdir(os.sep.join(cantera_root + ['test', 'work'])) | ||
| CANTERA_ROOT = Path(__file__).parents[2] | ||
| os.chdir(str(CANTERA_ROOT / "test" / "work")) |
There was a problem hiding this comment.
I'm not a big fan of chdir, I find that it leads to confusion about where files will be placed. Hopefully we can just get rid of this file entirely someday, since we don't need all the stuff that we had for compatibility with unittest that are in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
pytestfor Python test suitepytestfeatures can be used in unit testsIf applicable, fill in the issue number this pull request is fixing
Addresses Cantera/enhancements#128
Checklist
scons build&scons test) and unit tests address code coverage