Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to full C++11 standard #1119

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Update to full C++11 standard #1119

merged 2 commits into from
Oct 17, 2021

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Oct 16, 2021

Changes proposed in this pull request

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Thoughts

  • MSVC uses C++14 by default (can be specified via /std:c++14 after Visual Studio 2015 Update 3 - see here)
  • Not sure whether the Cygwin work-around (-std=gnu++11) is still necessary ... probably yes

@codecov
Copy link

codecov bot commented Oct 16, 2021

Codecov Report

Merging #1119 (f7d5e9a) into main (be95118) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1119   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files         364      364           
  Lines       47882    47882           
=======================================
  Hits        35170    35170           
  Misses      12712    12712           
Impacted Files Coverage Δ
src/thermo/PengRobinson.cpp 88.26% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27eb1f...f7d5e9a. Read the comment docs.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@speth speth merged commit a84b6e6 into Cantera:main Oct 17, 2021
@ischoegl ischoegl deleted the c++11 branch October 20, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants