-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests when not building the Python package + other minor fixes #1100
Conversation
This allows these tests to work even when the Python package is not present.
Converting between different mechanism formats require at least the "minimal" Python package to be built.
This was generating warnings from Clang.
In the default case where the 'python_prefix' variable is '$prefix', the Python module would get installed to the literal '$prefix' subdirectory of the staging directory, instead of actually expanding the '$prefix' variable. Fixes a regression introduced in c7a5d18.
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 73.49% 73.49% -0.01%
==========================================
Files 364 364
Lines 47750 47749 -1
==========================================
- Hits 35096 35095 -1
Misses 12654 12654
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the regression!
Changes proposed in this pull request
stage_dir
location (fixes regression from c7a5d18)UnknownThermoPhaseModel
andUnknownKineticsModel
exception classesIf applicable, fill in the issue number this pull request is fixing
Closes #1095
Checklist
scons build
&scons test
) and unit tests address code coverage