Fix extinction temperature definition in diffusion_flame_extinction.py #1066
Conversation
…sistancy with the use of np.isclose() for the extinciton criteria in Cantera 2.5 version of this Python example
| @@ -114,6 +114,7 @@ | |||
| strain_factor = alpha[-1] / alpha[n_last_burning] | |||
| # Create an initial guess based on the previous solution | |||
| # Update grid | |||
| # NB: Grid scaling changes the diffusion flame width | |||
There was a problem hiding this comment.
As a minor suggestion to improve readability, we're trying to avoid use of some more obscure abbreviations, especially these Latin ones, so I would just write "note" here.
There was a problem hiding this comment.
I guess 'NB' is a habit I picked up in British boarding school that I use without thinking about much :-) I will note well that it is now arcane and obscure!
Codecov Report
@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
+ Coverage 73.04% 73.07% +0.02%
==========================================
Files 357 358 +1
Lines 46925 46956 +31
==========================================
+ Hits 34277 34311 +34
+ Misses 12648 12645 -3
Continue to review full report at Codecov.
|
Assigning extinction temperature based on inlet temperatures, for consistancy with the use of np.isclose() for the extinction criteria in Cantera 2.5 version of this Python example. Otherwise the extinction criteria only works if temperature_limit_extinction is set equal to the higher gas inlet temperature.
Closes #1064