Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConstDensityThermo standardConcentration is incorrect #458

Closed
decaluwe opened this issue Jun 28, 2017 · 0 comments
Closed

ConstDensityThermo standardConcentration is incorrect #458

decaluwe opened this issue Jun 28, 2017 · 0 comments

Comments

@decaluwe
Copy link
Member

decaluwe commented Jun 28, 2017

Cantera version:

2.3.0

Operating System:

All

Expected Behavior:

constDensityThermo, as the name implies, holds the mass density (kg/m3) of the phase fixed. The standard concentration for species k should therefore be the molarDensity when X_k = 1, i.e.

standardConcentration(k) = density()/molecularWeight(k)

Actual Behavior:

Instead, ConstDensityThermo:standardConcentration returns molarDensity(), meaning the standard concentration varies with the composition of the phase. This is incorrect, in and of itself, but also implies that the kinetics are handled incorrectly for this phase: for any thermodynamically reversible reaction where the number of product and reactant species in this phase are not equal (i.e. for certain interfacial reactions), k_f will be a function of X_k, which is clearly problematic.

The fix is relatively straightforward, and I'll submit a PR in short order, but just wanted to document and make sure I'm thinking about this correctly.

decaluwe added a commit to decaluwe/cantera that referenced this issue Dec 5, 2017
Fixes Cantera#458.  standardConcentration for species k is calculated as
density()/molecularWeight(k).  Note that any species with a
molecularWeight of zero (i.e. a vacancy) will cause problems, and
should be avoided for this phase.

For this reason, sofc-text.xml also had to be changed and models
the YSZ electrolyte as an `IdealSolidSolution`, rather than as
`incompressible_solid`.
@speth speth closed this as completed in #490 Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant