Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NasaThermo::reportParams fails... #328

Closed
nogenmyr opened this issue Mar 23, 2016 · 2 comments
Closed

NasaThermo::reportParams fails... #328

nogenmyr opened this issue Mar 23, 2016 · 2 comments

Comments

@nogenmyr
Copy link

I have a code that wants to access the Nasa polynomial coefficients for the loaded species. This I do through NasaThermo::reportParams(...). In that method there is a check that some two specie index variables match (if (n != index) {..)

It appears however that the integer n above is not set by the called NasaPoly1::reportParameters(...), but it remains zero at all times. Hence, I can only get the coefficients for specie 0 (when both n and index are 0). If I simply comment the check above the code works and the correct coefficients are returned. NasaPoly1::reportParameters(...) uses the deprecated integer m_index to set n, and m_index is not set properly anymore (this used to work a year ago)

Kalle

@speth
Copy link
Member

speth commented Mar 23, 2016

What version of Cantera are you using? Class NasaThermo was deprecated in 2.2, and has since been removed. You should just be using class GeneralSpeciesThermo which works with all individual species thermo types.

@nogenmyr
Copy link
Author

I use 2.1.2, where I had no issues with this. The problem occurred when a colleague wanted to use my code, but he installed Cantera 2.2 (downloaded in say, October). I just downloaded 2.2.1, but I can see the NasaThermo class code is still there. Maybe it is not intended to be used. Thank you for pointing me to the GeneralSpeciesThermo class... I will revise my code to use that class instead!

speth added a commit that referenced this issue Mar 28, 2016
These functions were making checks based on the old style of handling species
indexing which no longer applies.

Fixes #328
@speth speth closed this as completed Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants