Incorporate review suggestions

samples/cxx/custom/custom.cpp

@@ -1,10 +1,15 @@
-/* @file custom.cpp
+/*!
+ * @file custom.cpp
  * Solve a closed-system constant pressure ignition problem where the governing equations
  * are custom-implemented.
  */
 
+// This file is part of Cantera. See License.txt in the top-level directory or
+// at https://cantera.org/license.txt for license and copyright information.
+
 #include "cantera/thermo.h"
 #include "cantera/kinetics.h"
+#include "cantera/base/Solution.h"
 #include "cantera/numerics/Integrator.h"
 #include <fstream>
 
@@ -21,36 +26,37 @@ class ReactorODEs : public FuncEval {
 
         // pointer to the system's ThermoPhase object. updated by the solver during
         // simulation to provide iteration-specific thermodynamic properties.
-        gas = sol->thermo();
+        m_gas = sol->thermo();
 
         // pointer to the kinetics manager. provides iteration-specific species
         // production rates based on the current state of the ThermoPhase.
-        kinetics = sol->kinetics();
+        m_kinetics = sol->kinetics();
 
         // the system's constant pressure, taken from the provided initial state.
-        pressure = gas->pressure();
+        m_pressure = m_gas->pressure();
 
         // number of chemical species in the system.
-        nSpecies = gas->nSpecies();
+        m_nSpecies = m_gas->nSpecies();
 
         // resize the vector_fp storage containers for species partial molar enthalpies
         // and net production rates. internal values are updated and used by the solver
         // per iteration.
-        hbar.resize(nSpecies);
-        wdot.resize(nSpecies);
+        m_hbar.resize(m_nSpecies);
+        m_wdot.resize(m_nSpecies);
 
         // number of equations in the ODE system. a conservation equation for each
         // species, plus a single energy conservation equation for the system.
-        nEqs = nSpecies + 1;
+        m_nEqs = m_nSpecies + 1;
     }
 
     /**
      * Evaluate the ODE right-hand-side function, ydot = f(t,y).
-     *   - overrided from FuncEval, called by the integrator during simulation.
+     *   - overridden from FuncEval, called by the integrator during simulation.
      * @param[in] t time.
      * @param[in] y solution vector, length neq()
      * @param[out] ydot rate of change of solution vector, length neq()
      * @param[in] p sensitivity parameter vector, length nparams()
+     *   - note: sensitivity analysis isn't implemented in this example
      */
     void eval(double t, double* y, double* ydot, double* p) {
         // the solution vector *y* is [T, Y_1, Y_2, ... Y_K], where T is the
@@ -67,14 +73,14 @@ class ReactorODEs : public FuncEval {
         /* ------------------------- UPDATE GAS STATE ------------------------- */
         // the state of the ThermoPhase is updated to reflect the current solution
         // vector, which was calculated by the integrator.
-        gas->setMassFractions_NoNorm(massFracs);
-        gas->setState_TP(temperature, pressure);
+        m_gas->setMassFractions_NoNorm(massFracs);
+        m_gas->setState_TP(temperature, m_pressure);
 
         /* ----------------------- GET REQ'D PROPERTIES ----------------------- */
-        double rho = gas->density();
-        double cp = gas->cp_mass();
-        gas->getPartialMolarEnthalpies(&hbar[0]);
-        kinetics->getNetProductionRates(&wdot[0]);
+        double rho = m_gas->density();
+        double cp = m_gas->cp_mass();
+        m_gas->getPartialMolarEnthalpies(&m_hbar[0]);
+        m_kinetics->getNetProductionRates(&m_wdot[0]);
 
         /* -------------------------- ENERGY EQUATION ------------------------- */
         // the rate of change of the system temperature is found using the energy
@@ -83,8 +89,9 @@ class ReactorODEs : public FuncEval {
         // or equivalently:
         //     dT/dt = - sum[hbar(k) * dw(k)/dt] / (rho * cp)
         double hdot_vol = 0;
-        for (int k = 0; k < nSpecies; k++)
-            hdot_vol += hbar[k] * wdot[k];
+        for (size_t k = 0; k < m_nSpecies; k++) {
+            hdot_vol += m_hbar[k] * m_wdot[k];
+        }
         *dTdt = - hdot_vol / (rho * cp);
 
         /* --------------------- SPECIES CONSERVATION EQS --------------------- */
@@ -93,44 +100,45 @@ class ReactorODEs : public FuncEval {
         //     m*dY(k)/dt = dm(k)/dt
         // or equivalently:
         //     dY(k)/dt = dw(k)/dt * MW(k) / rho
-        for (int k = 0; k < nSpecies; k++)
-            dYdt[k] = wdot[k] * gas->molecularWeight(k) / rho;
+        for (size_t k = 0; k < m_nSpecies; k++) {
+            dYdt[k] = m_wdot[k] * m_gas->molecularWeight(k) / rho;
+        }
     }
 
     /**
      * Number of equations in the ODE system.
-     *   - overrided from FuncEval, called by the integrator during initialization.
+     *   - overridden from FuncEval, called by the integrator during initialization.
      */
     size_t neq() {
-        return nEqs;
+        return m_nEqs;
     }
 
     /**
      * Provide the current values of the state vector, *y*.
-     *   - overrided from FuncEval, called by the integrator during initialization.
+     *   - overridden from FuncEval, called by the integrator during initialization.
      * @param[out] y solution vector, length neq()
      */
     void getState(double* y) {
         // the solution vector *y* is [T, Y_1, Y_2, ... Y_K], where T is the
         // system temperature, and Y_k is the mass fraction of species k.
-        y[0] = gas->temperature();
-        gas->getMassFractions(&y[1]);
+        y[0] = m_gas->temperature();
+        m_gas->getMassFractions(&y[1]);
     }
 
 private:
     // private member variables, to be used internally.
-    shared_ptr<ThermoPhase> gas;
-    shared_ptr<Kinetics> kinetics;
-    vector_fp hbar;
-    vector_fp wdot;
-    double pressure;
-    int nSpecies;
-    int nEqs;
+    shared_ptr<ThermoPhase> m_gas;
+    shared_ptr<Kinetics> m_kinetics;
+    vector_fp m_hbar;
+    vector_fp m_wdot;
+    double m_pressure;
+    size_t m_nSpecies;
+    size_t m_nEqs;
 };
 
 int main() {
     /* -------------------- CREATE GAS & SPECIFY STATE -------------------- */
-    auto sol = newSolution("gri30.yaml");
+    auto sol = newSolution("gri30.yaml", "gri30", "None");
     auto gas = sol->thermo();
     gas->setState_TPX(1001, OneAtm, "H2:2, O2:1, N2:4");
 
@@ -142,9 +150,10 @@ int main() {
 
     // for convenience, a title for each of the state vector's components is written to
     // the first line of the csv file.
-    outputFile << "time (s), temp (K), ";
-    for (int k = 0; k < gas->nSpecies(); k++)
-        outputFile << "Y_" << gas->speciesName(k) << ", ";
+    outputFile << "time (s), temp (K)";
+    for (size_t k = 0; k < gas->nSpecies(); k++) {
+        outputFile << ", Y_" << gas->speciesName(k);
+    }
     outputFile << std::endl;
 
     /* --------------------- CREATE ODE RHS EVALUATOR --------------------- */
@@ -167,7 +176,7 @@ int main() {
     //     relative tolerance: 1.0e-9
     //     absolute tolerance: 1.0e-15
     //     max step size: +inf
-    Integrator *integrator = newIntegrator("CVODE");
+    std::unique_ptr<Integrator> integrator(newIntegrator("CVODE"));
 
     // initialize the integrator, specifying the start time and the RHS evaluator object.
     // internally, the integrator will apply settings, allocate needed memory, and populate
@@ -185,9 +194,10 @@ int main() {
         // output the current absolute time and solution state vector to the csv file. you can view
         // these results by opening the "custom_cxx.csv" file that appears in this program's directory
         // after compiling and running.
-        outputFile << tnow << ", ";
-        for (int i = 0; i < odes.neq(); i++)
-            outputFile << solution[i] << ", ";
+        outputFile << tnow;
+        for (size_t i = 0; i < odes.neq(); i++) {
+            outputFile << ", " << solution[i];
+        }
         outputFile << std::endl;
 
         // increment the simulation's absolute time, tnow, then return to the start of the loop to