Skip to content

Commit

Permalink
[SCons] Fix AttributeError when generating license
Browse files Browse the repository at this point in the history
Older versions of SCons do not support dictionary value-types. Instead,
these must be explicitly cast to lists so that SCons can process all the
files.

Fixes Attribute error during build #1147
  • Loading branch information
bryanwweber authored and speth committed Dec 12, 2021
1 parent 60c4a81 commit c7c2082
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions ext/SConscript
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,12 @@ def generate_license(target, source, env):


localenv["license_files"] = license_files
license = build(localenv.Command("LICENSE.txt", license_files.values(),
license = build(localenv.Command("LICENSE.txt", list(license_files.values()),
generate_license))
env["license_target"] = license
install('$inst_docdir', license)

if env['OS'] == 'Windows':
# RTF version is required for Windows installer
build(localenv.Command("LICENSE.rtf", license_files.values(),
build(localenv.Command("LICENSE.rtf", list(license_files.values()),
generate_license))

0 comments on commit c7c2082

Please sign in to comment.