Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wren-ui): Detects schema change - table & column #339

Closed
wants to merge 13 commits into from

Conversation

andreashimin
Copy link
Contributor

@andreashimin andreashimin commented May 30, 2024

Description

  • Get schema change API - Query
    query SchemaChange {
        schemaChange {
          deletedTables
          deletedColumns
          modifiedColumns
       }
    }
  • Trigger schema change API - Mutation
     mutation Mutation {
        triggerDataSourceDetection
     }
  • Resolve schema change API - Mutation
     # The modified columns is not support for resolving schema changes
     enum SchemaChangeType {
       DELETED_TABLES
       DELETED_COLUMNS
       MODIFIED_COLUMNS
     }
    
     input ResolveSchemaChangeWhereInput {
       type: SchemaChangeType!
     }
    
     mutation Mutation($where: ResolveSchemaChangeWhereInput!) {
       resolveSchemaChange(where: $where)
     }

@andreashimin andreashimin force-pushed the feature/schema-changes branch from d0a790c to 3a8947a Compare June 11, 2024 11:22
@andreashimin andreashimin changed the base branch from main to epic/ibis June 11, 2024 11:36
@andreashimin andreashimin marked this pull request as ready for review June 12, 2024 01:55
@andreashimin andreashimin requested a review from wwwy3y3 June 12, 2024 01:55
onlyjackfrost and others added 5 commits June 12, 2024 16:10
* feat: Add ibis adaptor for querying supported data sources

* feat: Add testIbis resolver for querying supported data sources

* feat: use queryService for preview and describe statement

* feat: Refactor ibisAdaptor to use DataSourceName enum consistently

* test ibis using tpch query

* rm test ibis

* feat: Add previewSql resolver for SQL preview

* rm debug log

* use projectId and manifest to generate hash
Implement getMDL api

* pass mdl to ibis server to preview

* transform manifest data type to json object when retrieved from database

* better error message from Ibis server, rewrite host when development and using docker

* use base64 str to transfer mdl

* update README

* change env name to fit naming style.
update docker-compose.x.yaml and .env.example file

* fix yarn build issue

* update docker-compose file: fix incorrent ibis server endpoint

* port forward to ibis server

* fix incorrect migration rollback function

* update engine version

* Chore: refactor database schema to reflect how we use them. (#341)

* add connectionInfo column and do data migration

* drop deprecated columns that store connection info, use connectionInfo column instead

* do data migration to store tableReference in model's properties

* fix incorrect migration rollback function

* use tableReference in mdl instead of refSql

* chore: Update variable names in ibisAdaptor and queryService

* chore: Update variable names in ibisAdaptor and queryService

* fix lint

* rename variable in ibis adaptor

* - remove duplicate logic to parse string
- add comment
…dd-in used (#373)

* fix(wren-ui): add displayName to all view API which share ViewInfo type in graphQL

* feat(wren-ui): provide limit property of preview API for usage in excel-add-in
* chore: Update ibisAdaptor to include methods for getting tables and constraints

* remove strategies and connectors from codebase, use ibis server and wrenEngine to fetch metadata of data source

* add validation rule api in ibisAdapter

* replace invalid char when generating referenceName

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants