Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase assertion tolerance for Python inference #70

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

ElliottKasoar
Copy link
Contributor

@ElliottKasoar ElliottKasoar commented Nov 22, 2023

Increase the tolerance slightly to match the example Fortran tolerance, as the results may only match to around five significant figures.

(Without this change, it threw an assertion error for me when running python resnet_infer_python.py)

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably OK.
Does it need changing on exercise 1 as well?

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked, and the answer is no, as we only print for the user to check there.
Will merge now.

@jatkinson1000 jatkinson1000 merged commit 2b87551 into main Nov 23, 2023
2 checks passed
@jatkinson1000 jatkinson1000 deleted the fix-tol branch November 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants