-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake fix #67
CMake fix #67
Conversation
Both examples seem to work for me on WSL (Ubuntu 20.04) I assume we're not updating the work-in-progress example for now? Worth noting we'll need to update the benchmarking repo too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about glob patterns in LDFLAGS
suggestions in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but not happy with *
OK, made everything |
Co-authored-by: ElliottKasoar <45317199+ElliottKasoar@users.noreply.github.com>
I believe this closes #14
Namely the comments below the main one regarding install location.
cmake files are now placed at
$CMAKE_INSTALL_PREFIX/lib/cmake/FTorch/
allowing CMake to locate things automatically if passedCMAKE_PREFIX_PATH = $CMAKE_INSTALL_PREFIX
.This means we no longer specify the
FTorch_DIR
argument, instead usingCMAKE_PREFIX_PATH
as standard.Regarding the other items in #14:
Tested on apple M1 mac to build library, install, and build/run examples 1 and 2.
Would appreciate someone else replicating on a different system.