Looping example #169
Merged
Looping example #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jatkinson1000
added
documentation
jatkinson1000
force-pushed
the
looping-example
branch
2 times, most recently
from
8745513
to
1825824
Compare
jwallwork23
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
This all looks good to me, thanks @jatkinson1000. Just some minor comments and suggestions.
| @@ -3,5 +3,6 @@ if(CMAKE_BUILD_TESTS) | |||
| add_subdirectory(2_ResNet18) | |||
| # add_subdirectory(3_MultiGPU) | |||
| add_subdirectory(4_MultiIO) | |||
| add_subdirectory(5_Autograd) | |||
| # add_subdirectory(5_Looping) | |||
There was a problem hiding this comment.
If this gets merged first then I can add tests for it in #166.
There was a problem hiding this comment.
That is an option, though I think this one isn't really 'testing' anything, but rather demonstrating, so for the sake of saving time/resource in the test suite it could be left.
I'll let you decide in #166
…tran with instructions on how to do this.
jatkinson1000
force-pushed
the
looping-example
branch
from
c06f220
to
d69d51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds an example to demonstrate how best to structure code when inference is being called many times as part of an iterative procedure.
It demonstrates two approaches, the 'bad' naive way following exercise 1, and the 'good' substructured way.
Users are guided through both codes before building and then and timing them to see the significant performance increase of the 'good' approach.
Review of the explanations, instructions, code, and a check that things can be build and run correctly appreciated.