Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requires_grad optional argument #150

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

jwallwork23
Copy link
Contributor

Closes #149.

Needed to switch requires_grad_opt -> requires_grad and use requires_grad_value to handle defaults (as with device_index).

Tested in my autograd example.

@jwallwork23 jwallwork23 added the bug Something isn't working label Jul 3, 2024
@jwallwork23 jwallwork23 self-assigned this Jul 3, 2024
@jwallwork23
Copy link
Contributor Author

Similarly for is_training.

@jwallwork23
Copy link
Contributor Author

Oh and for rtol in the ResNet example, for consistency.

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwallwork23
This is all sensible, thanks.

I suggest you add docs for these as part of #139 or similar.

@jatkinson1000 jatkinson1000 merged commit 490272e into main Jul 3, 2024
5 checks passed
@jwallwork23 jwallwork23 deleted the fix-requires-grad branch July 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix requires_grad optional argument
2 participants