-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing E2E tests #319
Fixing E2E tests #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
tests/coreTests.ts:11
- The change in URL path from '/sandbox' to '/anyparser' should be covered by tests to ensure the new behavior is verified.
await page.goto('/anyparser');
tests/coreTests.ts:18
- The change in URL path from '/sandbox' to '/anyparser' should be covered by tests to ensure the new behavior is verified.
await page.waitForURL('**/anyparser', { timeout: 5000 });
tests/coreTests.ts:22
- The change in URL path from '/sandbox' to '/anyparser' should be covered by tests to ensure the new behavior is verified.
await page.goto('/anyparser');
tests/coreTests.ts:43
- The change in URL path from '/sandbox' to '/anyparser' should be covered by tests to ensure the new behavior is verified.
await page.waitForURL('**/anyparser', { timeout: 5000 });
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
User description
Description
After we've changed the parser location from
/sandbox
to/anyparser
, we can't pass the login test.This PR fixes this problem.
However, currently there are other tests are failed which haven't been fixed yet. Let's work on them soon.
Related Issue
Type of Change
How Has This Been Tested?
Screenshots (if applicable)
Problem fixed
Problem awaiting to be fixed
Checklist
Additional Notes
PR Type
Bug fix, Tests
Description
/sandbox
to/anyparser
in thelogin
andsignup
functions.page.goto
andpage.waitForURL
calls in the test file reflect the new path.Changes walkthrough 📝
coreTests.ts
Update E2E test paths to `/anyparser`
tests/coreTests.ts
page.goto
andpage.waitForURL
calls to replace/sandbox
with
/anyparser
.location.